Summary: | Refactor ShapeOutsideInfo so it isn't mutated for each line | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Bem Jones-Bey <bjonesbe> | ||||||||||||
Component: | Layout and Rendering | Assignee: | Bem Jones-Bey <bjonesbe> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Bem Jones-Bey
2014-08-08 17:44:24 PDT
Created attachment 236327 [details]
Patch
Created attachment 236330 [details]
Patch
Rebased so it will actually apply.
Created attachment 236454 [details]
Patch
Rearrange bool members of ShapeOutsideDeltas to get more efficient layout.
Comment on attachment 236454 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236454&action=review > Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:336 > + return m_shapeOutsideDeltas; You don't need this return. Comment on attachment 236454 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236454&action=review >> Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:336 >> + return m_shapeOutsideDeltas; > > You don't need this return. You're right. I'll fix that. Created attachment 236462 [details]
Patch
Remove extra return statement
Comment on attachment 236462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236462&action=review r=me > Source/WebCore/rendering/shapes/ShapeOutsideInfo.h:47 > + WTF_MAKE_FAST_ALLOCATED; Since ShapeOutsideDeltas isn't instantiated by operator new, you don't need to make it fast allocated. Created attachment 236538 [details]
Patch
Remove unneeded fast allocation for ShapeOutsideDeltas
Comment on attachment 236538 [details] Patch Clearing flags on attachment: 236538 Committed r172529: <http://trac.webkit.org/changeset/172529> All reviewed patches have been landed. Closing bug. |