Bug 135780

Summary: Load the layout test result image diff HTML from a file, rather than having it inline in webkitpy
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, ddkilzer, dfarler, glenn, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dbates: review+

Description Simon Fraser (smfr) 2014-08-08 17:12:40 PDT
Load the layout test result image diff HTML from a file, rather than having it inline in webkitpy
Comment 1 Simon Fraser (smfr) 2014-08-08 17:13:42 PDT
Created attachment 236326 [details]
Patch
Comment 2 Tim Horton 2014-08-08 17:14:58 PDT
Comment on attachment 236326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236326&action=review

> LayoutTests/fast/harness/image-diff-template.html:15
> +var preloadedImageCount = 0;

indentationplz

> LayoutTests/fast/harness/image-diff-template.html:26
> +image.addEventListener('load', preloadComplete);

here too
Comment 3 Daniel Bates 2014-08-08 17:15:31 PDT
Comment on attachment 236326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236326&action=review

> Tools/ChangeLog:8
> +        Pull the HTML the image diff file into a separate file, for easier hackability.

This sentence doesn't read well.
Comment 4 Daniel Bates 2014-08-08 17:17:08 PDT
Comment on attachment 236326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236326&action=review

> LayoutTests/fast/harness/image-diff-template.html:10
> +<div class=imageText></div>
> +<div class=imageContainer data-prefix="%(prefix)s">Loading...</div>

Nit: I know you are just copying and pasting this markup. We should add quotes are the value of the HTML class attribute.
Comment 5 Daniel Bates 2014-08-08 17:17:52 PDT
(In reply to comment #4)
> (From update of attachment 236326 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236326&action=review
> 
> > LayoutTests/fast/harness/image-diff-template.html:10
> > +<div class=imageText></div>
> > +<div class=imageContainer data-prefix="%(prefix)s">Loading...</div>
> 
> Nit: [...] We should add quotes are the value of the HTML class attribute.

* We should add quotes around the value of the HTML class attribute.
Comment 6 Simon Fraser (smfr) 2014-08-08 17:24:12 PDT
https://trac.webkit.org/r172368