Summary: | [Services with UI] Action menu arrow hit testing is sometimes wrong | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Enrica Casucci <enrica> | ||||
Component: | WebCore Misc. | Assignee: | Enrica Casucci <enrica> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | beidson, thorton | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Enrica Casucci
2014-08-08 16:16:28 PDT
Created attachment 236322 [details]
Patch
Comment on attachment 236322 [details]
Patch
I stared at the rect math for like 5 minutes. Seems fine!
Comment on attachment 236322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236322&action=review > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:152 > + if (rects.isEmpty() || rects.size() == 1) should this just be rects.size() <= 1? > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:171 > + // Next stich together all the rects on the last line of the selection. s/stich/stitch/ > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:186 > + // indexFromEnd is the index of the last rectangle on the sendon the last line. "on the sendon"? (In reply to comment #3) > (From update of attachment 236322 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236322&action=review > > > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:152 > > + if (rects.isEmpty() || rects.size() == 1) > > should this just be rects.size() <= 1? Yes, it is better. > > > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:171 > > + // Next stich together all the rects on the last line of the selection. > > s/stich/stitch/ > > > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:186 > > + // indexFromEnd is the index of the last rectangle on the sendon the last line. > > "on the sendon"? Thanks for catching the typos. Committed revision 172395. |