Bug 135770

Summary: [CSS Grid Layout] Test coverage for first-line pseudo-element
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Tools / TestsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfernandez, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch none

Manuel Rego Casasnovas
Reported 2014-08-08 14:44:21 PDT
According to the spec the ::first-line pseudo-element do not apply to grid containers: "the ::first-line and ::first-letter pseudo-elements do not apply to grid containers." I'll provide a patch to add coverage for ::first-line which is already working as expected. ::first-letter needs some changes in the code, so it'd be done in a separated patch. This has already landed in Blink: https://src.chromium.org/viewvc/blink?view=rev&revision=179640
Attachments
Patch (5.52 KB, patch)
2014-08-08 14:48 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2014-08-08 14:48:37 PDT
Created attachment 236309 [details] Patch
Zoltan Horvath
Comment 2 2014-08-13 11:20:14 PDT
Comment on attachment 236309 [details] Patch r=me
WebKit Commit Bot
Comment 3 2014-09-02 01:36:25 PDT
Comment on attachment 236309 [details] Patch Clearing flags on attachment: 236309 Committed r173169: <http://trac.webkit.org/changeset/173169>
WebKit Commit Bot
Comment 4 2014-09-02 01:36:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.