Summary: | [GTK] No IPC messages are sent when building WebKitGTK+ with VERSION_SCRIPT | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | berto, bunhere, cdumez, commit-queue, gustavo, gyuyoung.kim, mrobinson, ossy, rakuco, sergio | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 135694 | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2014-08-08 11:05:46 PDT
Created attachment 236289 [details]
Patch
Comment on attachment 236289 [details]
Patch
o_O
Committed r172385: <http://trac.webkit.org/changeset/172385> (In reply to comment #3) > Committed r172385: <http://trac.webkit.org/changeset/172385> Unfortunately it broke the EFL build: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2%20%28Perf%29/builds/2883 It's strange why the EFL EWS didn't notice it before. Maybe ENABLE_DRT environment variable isn't set on them. The build fails on the EFL layout tester and the EFL performance tester bots where ENABLE_DRT is set to 1. But the build doesn't fail on the ARM bots of u-szeged where ENABLE_DRT isn't present. (In reply to comment #4) > (In reply to comment #3) > > Committed r172385: <http://trac.webkit.org/changeset/172385> > > Unfortunately it broke the EFL build: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2%20%28Perf%29/builds/2883 I'm sorry, I assumed green EWS was safe enough. > It's strange why the EFL EWS didn't notice it before. > Maybe ENABLE_DRT environment variable isn't set on them. > > The build fails on the EFL layout tester and the EFL performance > tester bots where ENABLE_DRT is set to 1. But the build doesn't > fail on the ARM bots of u-szeged where ENABLE_DRT isn't present. I guess we just need to add WTF to any other target. (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > Committed r172385: <http://trac.webkit.org/changeset/172385> > > > > Unfortunately it broke the EFL build: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2%20%28Perf%29/builds/2883 > > I'm sorry, I assumed green EWS was safe enough. > > > It's strange why the EFL EWS didn't notice it before. > > Maybe ENABLE_DRT environment variable isn't set on them. > > > > The build fails on the EFL layout tester and the EFL performance > > tester bots where ENABLE_DRT is set to 1. But the build doesn't > > fail on the ARM bots of u-szeged where ENABLE_DRT isn't present. > > I guess we just need to add WTF to any other target. Ok, so the difference between ENABLE_DRT present or not is that it uses -DSHARED_CORE=ON, which is very confusing IMO. So the problem is not building DRT or whatever, but building with SHARED_CORE (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (In reply to comment #3) > > > > Committed r172385: <http://trac.webkit.org/changeset/172385> > > > > > > Unfortunately it broke the EFL build: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2%20%28Perf%29/builds/2883 > > > > I'm sorry, I assumed green EWS was safe enough. > > > > > It's strange why the EFL EWS didn't notice it before. > > > Maybe ENABLE_DRT environment variable isn't set on them. > > > > > > The build fails on the EFL layout tester and the EFL performance > > > tester bots where ENABLE_DRT is set to 1. But the build doesn't > > > fail on the ARM bots of u-szeged where ENABLE_DRT isn't present. > > > > I guess we just need to add WTF to any other target. > > Ok, so the difference between ENABLE_DRT present or not is that it uses -DSHARED_CORE=ON, which is very confusing IMO. So the problem is not building DRT or whatever, but building with SHARED_CORE So, even though I don't understand why it fails, I guess we can just add WTF to the list of wk2 libs only when SHARED_CORE is ON (this will never be ON for GTK+) (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > (In reply to comment #4) > > > > (In reply to comment #3) > > > > > Committed r172385: <http://trac.webkit.org/changeset/172385> > > > > > > > > Unfortunately it broke the EFL build: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2%20%28Perf%29/builds/2883 > > > > > > I'm sorry, I assumed green EWS was safe enough. > > > > > > > It's strange why the EFL EWS didn't notice it before. > > > > Maybe ENABLE_DRT environment variable isn't set on them. > > > > > > > > The build fails on the EFL layout tester and the EFL performance > > > > tester bots where ENABLE_DRT is set to 1. But the build doesn't > > > > fail on the ARM bots of u-szeged where ENABLE_DRT isn't present. > > > > > > I guess we just need to add WTF to any other target. > > > > Ok, so the difference between ENABLE_DRT present or not is that it uses -DSHARED_CORE=ON, which is very confusing IMO. So the problem is not building DRT or whatever, but building with SHARED_CORE > > So, even though I don't understand why it fails, I guess we can just add WTF to the list of wk2 libs only when SHARED_CORE is ON (this will never be ON for GTK+) This is long term issue on EFL port. Currently EFL port can't run layout test without SHARED_CORE=ON. To fix this issue, I filed a bug. However, it is still opened. [EFL] Can't run layout test without SHARED_CORE=ON https://bugs.webkit.org/show_bug.cgi?id=80683 It looks EFL EWS doesn't enable SHARED_CORE yet though buildbot enables it. That's why EWS didn't detect this build break. Let me talk how to fix this problem with my co-workers soon. Anyway, I add WTF library for EFL port at the moment. http://trac.webkit.org/changeset/172392 |