Bug 135694 - [GTK] REGRESSION(r166239): The ld version script is not being used
Summary: [GTK] REGRESSION(r166239): The ld version script is not being used
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on: 135760
  Show dependency treegraph
Reported: 2014-08-07 01:19 PDT by Alberto Garcia
Modified: 2014-08-10 00:30 PDT (History)
8 users (show)

See Also:

Patch (3.46 KB, patch)
2014-08-08 04:26 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff
Patch for landing (3.55 KB, patch)
2014-08-10 00:15 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2014-08-07 01:19:19 PDT
The symbols.filter script contains the list of symbols that are local and visible outside of the webkit library.

Source/cmake/OptionsGTK.cmake contains the following line:

    set(VERSION_SCRIPT "-Wl,--version-script,${CMAKE_SOURCE_DIR}/Source/autotools/symbols.filter")

However we don't seem to be using it and that variable is not referenced anywhere else (and that's anyway the old path, it was moved to Tools/gtk when we switched to cmake).
Comment 1 Carlos Garcia Campos 2014-08-08 04:26:29 PDT
Created attachment 236276 [details]
Comment 2 Carlos Garcia Campos 2014-08-08 11:14:43 PDT
I guess the eflsymbols.filter file is not up to date, or it's only for WebKit1, or whatever, anyway I'll add the VERSION_SCRIPT to LDFLAGS only for GTK then.
Comment 3 Carlos Garcia Campos 2014-08-10 00:15:55 PDT
Created attachment 236341 [details]
Patch for landing
Comment 4 Carlos Garcia Campos 2014-08-10 00:30:52 PDT
Committed r172377: <http://trac.webkit.org/changeset/172377>