Bug 135755

Summary: Services overlay dropdown is often in the wrong place with zoomed pages or horizontal scrolling
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, enrica
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch beidson: review+

Description Tim Horton 2014-08-08 02:53:42 PDT
DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection adjust the location of the button based on the visible rect, trying to keep the button visible.

We're handing it the wrong visible rect, though, not taking scrolling into account.

This leads to pages that scroll horizontally showing the button on the left even if there's space for it on the right, or sometimes not showing it at all.

<rdar://problem/17907752>
Comment 1 Tim Horton 2014-08-08 02:56:03 PDT
Created attachment 236275 [details]
patch
Comment 2 Tim Horton 2014-08-08 09:23:05 PDT
http://trac.webkit.org/changeset/172344