Summary: | [WebAudio] FFTFrame is cluttered with dead code | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
Component: | Web Audio | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, crogers, eric.carlson, glenn, jer.noble, philipj, pnormand, sergio | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Philippe Normand
2014-08-08 00:55:54 PDT
(In reply to comment #0) > There are currently 4 FFTFrame implementations but I think that only 2 are used, the one for Mac and the GStreamer implementation. > > FFTFrame.h has also some ifdefs WEBAUDIO_OPENMAX_DL_FFT which were specific to Chromium, I think we should remove this. > > Thoughts? Out with the old and unused! Ok, I'm too busy now but I'll prepare a patch next week. Created attachment 236354 [details]
Patch
Created attachment 236359 [details]
Patch
Also removing unused ifdefs from AudioArray.h
Comment on attachment 236359 [details]
Patch
Thanks Philippe!
Committed r172431: <http://trac.webkit.org/changeset/172431> |