Bug 135751

Summary: [WebAudio] FFTFrame is cluttered with dead code
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Web AudioAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, crogers, eric.carlson, glenn, jer.noble, philipj, pnormand, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch eric.carlson: review+

Philippe Normand
Reported 2014-08-08 00:55:54 PDT
There are currently 4 FFTFrame implementations but I think that only 2 are used, the one for Mac and the GStreamer implementation. FFTFrame.h has also some ifdefs WEBAUDIO_OPENMAX_DL_FFT which were specific to Chromium, I think we should remove this. Thoughts?
Attachments
Patch (25.12 KB, patch)
2014-08-11 00:34 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (25.74 KB, patch)
2014-08-11 02:13 PDT, Philippe Normand 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2014-08-08 08:43:15 PDT
(In reply to comment #0) > There are currently 4 FFTFrame implementations but I think that only 2 are used, the one for Mac and the GStreamer implementation. > > FFTFrame.h has also some ifdefs WEBAUDIO_OPENMAX_DL_FFT which were specific to Chromium, I think we should remove this. > > Thoughts? Out with the old and unused!
Philippe Normand
Comment 2 2014-08-08 09:08:58 PDT
Ok, I'm too busy now but I'll prepare a patch next week.
Philippe Normand
Comment 3 2014-08-11 00:34:49 PDT
Created attachment 236354 [details] Patch
Philippe Normand
Comment 4 2014-08-11 02:13:03 PDT
Created attachment 236359 [details] Patch Also removing unused ifdefs from AudioArray.h
Eric Carlson
Comment 5 2014-08-11 06:52:39 PDT
Comment on attachment 236359 [details] Patch Thanks Philippe!
Philippe Normand
Comment 6 2014-08-12 00:50:09 PDT
Committed r172431: <http://trac.webkit.org/changeset/172431>
Note You need to log in before you can comment on or make changes to this bug.