Bug 135745

Summary:

Web Inspector: breakpoints enabled state is not persisted across re-opening the inspector

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Brian Burg 2014-08-07 21:50:30 PDT

My hunch is that we force this setting to be on when we restore breakpoints. In DebuggerManager.setBreakpoint, it unconditionally enables breakpoints when they are set, to avoid the situation where the user sets a breakpoint and nothing happens. However, in this case the user isn't doing anything, so no need to dummy-proof it.

Comment 1 Radar WebKit Bug Importer 2014-08-07 21:51:11 PDT

<rdar://problem/17955768>

Comment 2 Joseph Pecoraro 2014-08-07 21:55:49 PDT

* STEPS TO REPRODUCE
1. Open inspector
2. Disable breakpoints
3. Close Inspector
4. Open Inspector
  => breakpoints should be disabled, but they are enabled

Comment 3 Joseph Pecoraro 2014-08-07 22:04:48 PDT

Created attachment 236265 [details]
[PATCH] Proposed Fix

Comment 4 WebKit Commit Bot 2014-08-07 23:53:44 PDT

Comment on attachment 236265 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 236265

Committed r172333: <http://trac.webkit.org/changeset/172333>

Comment 5 WebKit Commit Bot 2014-08-07 23:53:46 PDT

All reviewed patches have been landed.  Closing bug.