Bug 135744 – commit-log-message has extra blank line at the top of pre-populated message

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Joseph Pecoraro]

* SUMMARY
commit-log-message has extra blank line at the top of pre-populated message.

* NOTES
Caused by: <https://webkit.org/b/131727> Fix the commit-log-editor after r167243 and add more unit tests

My work flow is something like:

   1. Make change
   2. git add files
   3. prepare-ChangeLog --git-index
   4. git add ChangeLogs
   5. git commit
    => extra newline

[Joseph Pecoraro]

In my case, I have a single ChangeLog entry, so the $commonPrefix is empty. The extra newline gets added because of:

>       if (!$commonPrefix) {
>           push @result, normalizeLineEndings("\n", $endl);
>       }

[Joseph Pecoraro]

Created attachment 236264 [details]
[PATCH] Proposed Fix

[Csaba Osztrogonác]

Comment on attachment 236264 [details]
[PATCH] Proposed Fix

Sorry for the trouble and thanks for the fix. r=me.

[WebKit Commit Bot]

Comment on attachment 236264 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 236264

Committed r172339: <http://trac.webkit.org/changeset/172339>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.