REGRESSION(r172094): timeline views are blank after reloading in some situations

• Component: Web Inspector
• Status: RESOLVED FIXED

[Brian Burg]

Per Joe:

"1. Uncaught exception
showTimelineViewForType called with an undefined type from restoreFromCookie. You mentioned this should fix that problem:

-        if (selectedTimelineViewIdentifier === WebInspector.TimelineSidebarPanel.OverviewTimelineIdentifierCookieValue)
+        if (!selectedTimelineViewIdentifier || selectedTimelineViewIdentifier === WebInspector.TimelineSidebarPanel.OverviewTimelineIdentifierCookieValue)

2. Timeline views showing up completely blank

- reload a page with the inspector open => overview/specific views are blank
- make new selections in the timeline => views are still blank
- switch recordings => causes things to work, but you have to make a new time selection"

[Radar WebKit Bug Importer]

<rdar://problem/17955556>

[Brian Burg]

(1) is easy enough to fix.

For me, (2) manifests as the overview being shown for timeline 1 when timeline 2 is recording, and clicking on the timeline tree elements shows timelines for timeline 1 instead of 2. So it seems that we are showing timeline 1 by mistake, possibly right after showing the intended timeline. Without a debugger I can't be sure, so I'll try adding some logging.

[Brian Burg]

Created attachment 236270 [details]
Patch

[Brian Burg]

The patch fixes this issue, at least on my machine. Joe, let me know if you still run into the same problem.

[WebKit Commit Bot]

Comment on attachment 236270 [details]
Patch

Clearing flags on attachment: 236270

Committed r172337: <http://trac.webkit.org/changeset/172337>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

This works better, but I'm seeing an uncaught exception and some other issues. I'll file bugs.

file:///Users/pecoraro/Build/Release/WebInspectorUI.framework/Resources/Protocol/InspectorBackend.js:173:30: CONSOLE ERROR Uncaught exception in inspector page while dispatching callback for command Page.getResourceTree:  TypeError: undefined is not a function (evaluating 'candidateObjectCookie.every(function valuesMatchForKey(key) {
                return candidateObjectCookie[key] === cookie[key];
            })')
file:///Users/pecoraro/Build/Release/WebInspectorUI.framework/Resources/Views/NavigationSidebarPanel.js:702:77: CONSOLE ERROR TypeError: undefined is not a function (evaluating 'candidateObjectCookie.every(function valuesMatchForKey(key) {
                return candidateObjectCookie[key] === cookie[key];
            })')

[Joseph Pecoraro]

I'm guessing this issue was just a typo:

-            return candidateCookieKeys.length && candidateObjectCookie.every(function valuesMatchForKey(key) {
+            return candidateCookieKeys.length && candidateCookieKeys.every(function valuesMatchForKey(key) {