Summary: | Web Inspector: Fix accidental always true comparison | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Err, this would cause the comparison to always be true* Created attachment 236261 [details]
[PATCH] Proposed Fix
Comment on attachment 236261 [details]
[PATCH] Proposed Fix
Did my TreeOutline fix inspire you to search for this needle in a haystack?
Yes, this would be a performance improvement. Comment on attachment 236261 [details] [PATCH] Proposed Fix Clearing flags on attachment: 236261 Committed r172336: <http://trac.webkit.org/changeset/172336> All reviewed patches have been landed. Closing bug. |
* SUMMARY There is what looks like a typo in a comparison in OverviewTimelineView.js. > if (!this.currentTime !== oldCurrentTime) { > ^ -- why? This looks like an accident causing the comparison to always be false. Removing it, things still behave as expected. I know of no user impact from this change. Possible performance improvement?