Bug 135741

Summary: Web Inspector: Fix accidental always true comparison
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2014-08-07 20:57:40 PDT
* SUMMARY There is what looks like a typo in a comparison in OverviewTimelineView.js. > if (!this.currentTime !== oldCurrentTime) { > ^ -- why? This looks like an accident causing the comparison to always be false. Removing it, things still behave as expected. I know of no user impact from this change. Possible performance improvement?
Attachments
[PATCH] Proposed Fix (1.48 KB, patch)
2014-08-07 21:00 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-08-07 20:57:49 PDT
<rdar://problem/17955491>
Joseph Pecoraro
Comment 2 2014-08-07 20:58:55 PDT
Err, this would cause the comparison to always be true*
Joseph Pecoraro
Comment 3 2014-08-07 21:00:17 PDT
Created attachment 236261 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 4 2014-08-07 23:23:37 PDT
Comment on attachment 236261 [details] [PATCH] Proposed Fix Did my TreeOutline fix inspire you to search for this needle in a haystack?
Timothy Hatcher
Comment 5 2014-08-07 23:24:45 PDT
Yes, this would be a performance improvement.
WebKit Commit Bot
Comment 6 2014-08-07 23:57:49 PDT
Comment on attachment 236261 [details] [PATCH] Proposed Fix Clearing flags on attachment: 236261 Committed r172336: <http://trac.webkit.org/changeset/172336>
WebKit Commit Bot
Comment 7 2014-08-07 23:57:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.