Summary: | [mac] Dynamically update serviceability when the set of services changes | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||
Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | beidson, commit-queue, enrica | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Tim Horton
2014-08-07 19:38:47 PDT
Created attachment 236253 [details]
patch
Created attachment 236254 [details]
rebase
Attachment 236254 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/mac/ServicesController.mm:80: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 236254 [details] rebase View in context: https://bugs.webkit.org/attachment.cgi?id=236254&action=review > Source/WebKit2/UIProcess/WebContext.cpp:-92 > > -#if ENABLE(SERVICE_CONTROLS) > -#include "ServicesController.h" > -#endif I see, this was here because the header is in a directory that isn't in the search path for the other ports. I will undo this part! Comment on attachment 236254 [details]
rebase
Going to improve this a little.
Created attachment 236284 [details]
patch
Attachment 236284 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/mac/ServicesController.mm:80: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 236284 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=236284&action=review > Source/WebKit2/UIProcess/mac/ServicesController.mm:134 > + WTFLogAlways("refreshed %d", m_hasSelectionServices); :( 32-bit build fix http://trac.webkit.org/changeset/172369 |