Bug 135738 - [mac] Dynamically update serviceability when the set of services changes
Summary: [mac] Dynamically update serviceability when the set of services changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-07 19:38 PDT by Tim Horton
Modified: 2014-08-08 18:15 PDT (History)
3 users (show)

See Also:

Attachments
patch (10.07 KB, patch)
2014-08-07 19:45 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
rebase (10.23 KB, patch)
2014-08-07 19:48 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
patch (10.82 KB, patch)
2014-08-08 09:56 PDT, Tim Horton 		beidson: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-08-07 19:38:47 PDT 
<rdar://problem/17533459>
Comment 1 Tim Horton 2014-08-07 19:45:08 PDT 
Created attachment 236253 [details]
patch
Comment 2 Tim Horton 2014-08-07 19:48:05 PDT 
Created attachment 236254 [details]
rebase
Comment 3 WebKit Commit Bot 2014-08-07 19:48:58 PDT 
Attachment 236254 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ServicesController.mm:80:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2014-08-07 20:55:26 PDT 
Comment on attachment 236254 [details]
rebase

View in context: https://bugs.webkit.org/attachment.cgi?id=236254&action=review

> Source/WebKit2/UIProcess/WebContext.cpp:-92
>  
> -#if ENABLE(SERVICE_CONTROLS)
> -#include "ServicesController.h"
> -#endif

I see, this was here because the header is in a directory that isn't in the search path for the other ports. I will undo this part!
Comment 5 Tim Horton 2014-08-08 09:26:49 PDT 
Comment on attachment 236254 [details]
rebase

Going to improve this a little.
Comment 6 Tim Horton 2014-08-08 09:56:19 PDT 
Created attachment 236284 [details]
patch
Comment 7 WebKit Commit Bot 2014-08-08 09:57:20 PDT 
Attachment 236284 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ServicesController.mm:80:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Brady Eidson 2014-08-08 15:40:52 PDT 
Comment on attachment 236284 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236284&action=review

> Source/WebKit2/UIProcess/mac/ServicesController.mm:134
> +            WTFLogAlways("refreshed %d", m_hasSelectionServices);

:(
Comment 9 Tim Horton 2014-08-08 16:33:26 PDT 
http://trac.webkit.org/changeset/172366
Comment 10 Tim Horton 2014-08-08 18:15:33 PDT 
32-bit build fix http://trac.webkit.org/changeset/172369