Bug 135738 – [mac] Dynamically update serviceability when the set of services changes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

<rdar://problem/17533459>

[Tim Horton]

Created attachment 236253 [details]
patch

[Tim Horton]

Created attachment 236254 [details]
rebase

[WebKit Commit Bot]

Attachment 236254 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ServicesController.mm:80:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 236254 [details]
rebase

View in context: https://bugs.webkit.org/attachment.cgi?id=236254&action=review

> Source/WebKit2/UIProcess/WebContext.cpp:-92
>  
> -#if ENABLE(SERVICE_CONTROLS)
> -#include "ServicesController.h"
> -#endif

I see, this was here because the header is in a directory that isn't in the search path for the other ports. I will undo this part!

[Tim Horton]

Comment on attachment 236254 [details]
rebase

Going to improve this a little.

[Tim Horton]

Created attachment 236284 [details]
patch

[WebKit Commit Bot]

Attachment 236284 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ServicesController.mm:80:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Comment on attachment 236284 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236284&action=review

> Source/WebKit2/UIProcess/mac/ServicesController.mm:134
> +            WTFLogAlways("refreshed %d", m_hasSelectionServices);

:(

[Tim Horton]

http://trac.webkit.org/changeset/172366

[Tim Horton]

32-bit build fix http://trac.webkit.org/changeset/172369