Bug 135734

Summary: make clean does not work in OpenSource, fails in WebKitLibraries
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ddkilzer, fpizlo, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2014-08-07 16:48:57 PDT
* SUMMARY
`make clean` does not work because WebKitLibraries' Makefile is missing a "clean" target.

* STEPS TO REPRODUCE
shell> cd WebKitLibraries && make clean
Comment 1 Joseph Pecoraro 2014-08-07 16:51:20 PDT
Created attachment 236241 [details]
[PATCH] Proposed Fix
Comment 2 David Kilzer (:ddkilzer) 2014-08-08 11:24:32 PDT
Comment on attachment 236241 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=236241&action=review

r=me

> Tools/Scripts/copy-webkitlibraries-to-product-directory:311
> +    (system("rm", "-rf", "$productDir/usr/local/include/WebKitSystemInterface.h") == 0) or die;
> +    (system("rm", "-rf", "$productDir$llvmPrefix") == 0) or die;

I think you need to use the exitStatus() function (in VCSUtils.pm) to check the result of system() on Windows.

To put another way, I'm not sure if "system() == 0" will work on Windows.
Comment 3 Joseph Pecoraro 2014-08-08 11:46:50 PDT
Comment on attachment 236241 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=236241&action=review

>> Tools/Scripts/copy-webkitlibraries-to-product-directory:311
>> +    (system("rm", "-rf", "$productDir$llvmPrefix") == 0) or die;
> 
> I think you need to use the exitStatus() function (in VCSUtils.pm) to check the result of system() on Windows.
> 
> To put another way, I'm not sure if "system() == 0" will work on Windows.

The rest of this file uses this idiom. Spoke on IRC lets land as is.
Comment 4 WebKit Commit Bot 2014-08-08 12:20:43 PDT
Comment on attachment 236241 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 236241

Committed r172349: <http://trac.webkit.org/changeset/172349>
Comment 5 WebKit Commit Bot 2014-08-08 12:21:12 PDT
All reviewed patches have been landed.  Closing bug.