Bug 135700

Summary: [EFL] Do not initialize g_type in WebProcessMain::platformInitialize()
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: WebKit EFLAssignee: Grzegorz Czajkowski <g.czajkowski>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Grzegorz Czajkowski
Reported 2014-08-07 05:34:23 PDT
Inspired by Jinwoo commit (r171788). Glib since 2.36 itself initializes g_type_init.
Attachments
Patch (1.54 KB, patch)
2014-08-07 05:44 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2014-08-07 05:44:17 PDT
Created attachment 236186 [details] Patch
Ryuan Choi
Comment 2 2014-08-08 05:12:50 PDT
Comment on attachment 236186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236186&action=review Looks good to me. > Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:-101 > -#if !GLIB_CHECK_VERSION(2, 35, 0) > - g_type_init(); > -#endif > - Yes, we are using at least GLIB 2.38
Gyuyoung Kim
Comment 3 2014-08-08 19:04:09 PDT
Comment on attachment 236186 [details] Patch r=me.
WebKit Commit Bot
Comment 4 2014-08-08 19:37:52 PDT
Comment on attachment 236186 [details] Patch Clearing flags on attachment: 236186 Committed r172371: <http://trac.webkit.org/changeset/172371>
WebKit Commit Bot
Comment 5 2014-08-08 19:37:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.