Bug 135695

Summary: [GTK] Use WebKitNavigationAction also for WebKitNavigationPolicyDecision
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bunhere, cdumez, commit-queue, gustavo, gyuyoung.kim, mrobinson, sergio, svillar
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch gustavo: review+

Carlos Garcia Campos
Reported 2014-08-07 01:52:05 PDT
WebKitNavigationAction was introduced to extend WebKitWebView::create signal. Its API is mostly duplicated in WebKitNavigationPolicyDecision, so we can deprecate the duplicated methods and add webkit_navigation_policy_decision_get_navigation_data. This also makes it possible to know whether a navigation policy decision was triggered by a user gesture.
Attachments
Patch (33.50 KB, patch)
2014-08-07 02:09 PDT, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-08-07 02:09:01 PDT
Created attachment 236181 [details] Patch
WebKit Commit Bot
Comment 2 2014-08-07 02:10:50 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 3 2014-08-07 02:11:01 PDT
Attachment 236181 [details] did not pass style-queue: WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitNavigationPolicyDecision.h" WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitDefines.h" ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitPolicyClient.cpp:47: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitPolicyClient.cpp:53: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 4 2014-08-07 07:58:35 PDT
Committed r172211: <http://trac.webkit.org/changeset/172211>
Note You need to log in before you can comment on or make changes to this bug.