Bug 135687

Summary: [Win] Correct build errors when WebGL Disabled
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebGLAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino, kondapallykalyan, noam, roger_fong, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2014-08-06 20:43:06 PDT
Attempting to build with the WebGL feature disabled revealed a few problems: 1. The 'DebugSuffix' target was attempting to build Cairo graphics files in addition to the CG files needed for this target. 2. Several files were including headers that themselves included ANGLE and other WebGL-specific files. (a) platform/graphics/GLContext.cpp (b) platform/graphics/GraphicsContext3DPrivate.cpp (c) platform/graphics/opengl/GLPlatformContext.cpp (d) platform/graphics/opengl/GLPlatformSurface.cpp Although these files are configured to compile during non-WebGL builds, they are supposed to have appropriate compile guards so that no code is generated when the features are turned off. Consequently, these files needed the "#if ENABLE(3D_GRAPHICS)" macro to be moved higher in the file (or added, in the case of the GLPlatformContext.cpp and GLPlatformSurface.cpp).
Attachments
Patch (4.06 KB, patch)
2014-08-06 20:45 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-08-06 20:45:03 PDT
Created attachment 236171 [details] Patch
Radar WebKit Bug Importer
Comment 2 2014-08-06 20:45:50 PDT
<rdar://problem/17941465>
Brent Fulgham
Comment 3 2014-08-06 22:13:05 PDT
Committed in r172202. <http://trac.webkit.org/changeset/172202>
Note You need to log in before you can comment on or make changes to this bug.