Summary: | Services overlay flashes a lot; should have some hysteresis before showing overlay | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | beidson, commit-queue, enrica, esprehn+autocc, kangil.han, sam, simon.fraser | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2014-08-06 18:42:23 PDT
Created attachment 236166 [details]
patch
Comment on attachment 236166 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=236166&action=review > Source/WebCore/dom/Document.cpp:3523 > + /*ASSERT(m_inInvalidateNodeListAndCollectionCaches err. ignore this part. Comment on attachment 236166 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=236166&action=review > Source/WebKit2/WebProcess/WebPage/ServicesOverlayController.h:89 > + bool mouseIsOverHighlight(DDHighlightRef, bool& mouseIsOverButton); const method? > Source/WebKit2/WebProcess/WebPage/ServicesOverlayController.h:90 > + std::chrono::milliseconds remainingTimeUntilHighlightShouldBeShown(); const method? Created attachment 236168 [details]
patch
Made Simon's changes; turned off hysteresis for telephone number highlights (they're already nice and stable); made it so that clicking where the highlight would be won't show the menu unless the timeout has passed.
|