Bug 135683

Summary: Services overlay flashes a lot; should have some hysteresis before showing overlay
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, enrica, esprehn+autocc, kangil.han, sam, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
simon.fraser: review+
patch simon.fraser: review+

Tim Horton
Reported 2014-08-06 18:42:23 PDT
<rdar://problem/16878039>
Attachments
patch (12.79 KB, patch)
2014-08-06 19:30 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
patch (12.76 KB, patch)
2014-08-06 19:55 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-08-06 19:30:42 PDT
Created attachment 236166 [details] patch
Tim Horton
Comment 2 2014-08-06 19:31:45 PDT
Comment on attachment 236166 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=236166&action=review > Source/WebCore/dom/Document.cpp:3523 > + /*ASSERT(m_inInvalidateNodeListAndCollectionCaches err. ignore this part.
Simon Fraser (smfr)
Comment 3 2014-08-06 19:43:21 PDT
Comment on attachment 236166 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=236166&action=review > Source/WebKit2/WebProcess/WebPage/ServicesOverlayController.h:89 > + bool mouseIsOverHighlight(DDHighlightRef, bool& mouseIsOverButton); const method? > Source/WebKit2/WebProcess/WebPage/ServicesOverlayController.h:90 > + std::chrono::milliseconds remainingTimeUntilHighlightShouldBeShown(); const method?
Tim Horton
Comment 4 2014-08-06 19:55:30 PDT
Created attachment 236168 [details] patch Made Simon's changes; turned off hysteresis for telephone number highlights (they're already nice and stable); made it so that clicking where the highlight would be won't show the menu unless the timeout has passed.
Tim Horton
Comment 5 2014-08-06 19:58:48 PDT
http://trac.webkit.org/changeset/172200
Note You need to log in before you can comment on or make changes to this bug.