Bug 135672

Summary: Get rid of INPUT_SPEECH
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, kling, ossy, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Benjamin Poulain 2014-08-06 15:12:42 PDT 
Get rid of INPUT_SPEECH
Comment 1 Benjamin Poulain 2014-08-06 15:13:36 PDT 
Created attachment 236141 [details]
Patch
Comment 2 Benjamin Poulain 2014-08-06 17:23:31 PDT 
Created attachment 236157 [details]
Patch
Comment 3 Benjamin Poulain 2014-08-06 18:09:50 PDT 
Created attachment 236160 [details]
Patch
Comment 4 Benjamin Poulain 2014-08-07 14:04:41 PDT 
Comment on attachment 236160 [details]
Patch

Clearing flags on attachment: 236160

Committed r172259: <http://trac.webkit.org/changeset/172259>
Comment 5 Benjamin Poulain 2014-08-07 14:04:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Brent Fulgham 2014-08-07 16:53:34 PDT 
This broke the Windows build. I'll prep a change and check it in.
Comment 7 Brent Fulgham 2014-08-07 16:54:48 PDT 
Comment on attachment 236160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236160&action=review

> Tools/DumpRenderTree/TestRunner.h:-106
> -    void setMockSpeechInputDumpRect(bool flag);

These are still in win/TestRunnerWin.cpp
Comment 8 Simon Fraser (smfr) 2014-08-08 10:48:35 PDT 
Project fixup done in https://trac.webkit.org/r172345
Comment 9 Csaba Osztrogonác 2014-08-09 00:48:13 PDT 
(In reply to comment #6)
> This broke the Windows build. I'll prep a change and check it in.

and the buildfix landed in http://trac.webkit.org/changeset/172353