Summary: | Document-relative overlays disappear after doing page-cache navigations | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | Layout and Rendering | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2014-08-06 13:59:07 PDT
Created attachment 236132 [details]
patch
Comment on attachment 236132 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=236132&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:3439 > + Frame& frame = m_renderView.frameView().frame(); > + Page* page = frame.page(); > + if (!page) > + return; > + > + if (GraphicsLayer* overlayLayer = page->chrome().client().documentOverlayLayerForFrame(frame)) > + m_rootContentLayer->addChild(overlayLayer); Just call appendOverlayLayers()? http://trac.webkit.org/changeset/172179 As discussed, that's more work than it's worth. |