Bug 135658

Summary:

REGRESSION(r172094): tests fail because Inspector test harness does not include UIString

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Brian Burg <burg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	joepeck: review+

Description Brian Burg 2014-08-06 10:41:35 PDT

The timeline manager spins up during tests and makes a UIString for the first TimelineRecording's display name. But, localized strings are not currently included by Test.html.

Comment 1 Radar WebKit Bug Importer 2014-08-06 10:41:48 PDT

<rdar://problem/17933138>

Comment 2 Brian Burg 2014-08-06 11:01:28 PDT

Created attachment 236117 [details]
Patch

Comment 3 Joseph Pecoraro 2014-08-06 11:10:44 PDT

Comment on attachment 236117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236117&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Test.js:68
> +WebInspector.UIString = function(string) {
> +    // Don't localize strings when running tests.
> +    return string;
> +}

Style: Brace on new line
Nit: Comment doesn't seem necessary, this is straightforward.

Comment 4 Brian Burg 2014-08-06 11:32:54 PDT

Committed r172162: <http://trac.webkit.org/changeset/172162>