Bug 135658

Summary: REGRESSION(r172094): tests fail because Inspector test harness does not include UIString
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch joepeck: review+

Brian Burg
Reported 2014-08-06 10:41:35 PDT
The timeline manager spins up during tests and makes a UIString for the first TimelineRecording's display name. But, localized strings are not currently included by Test.html.
Attachments
Patch (1.50 KB, patch)
2014-08-06 11:01 PDT, Brian Burg 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-08-06 10:41:48 PDT
<rdar://problem/17933138>
Brian Burg
Comment 2 2014-08-06 11:01:28 PDT
Created attachment 236117 [details] Patch
Joseph Pecoraro
Comment 3 2014-08-06 11:10:44 PDT
Comment on attachment 236117 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236117&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Test.js:68 > +WebInspector.UIString = function(string) { > + // Don't localize strings when running tests. > + return string; > +} Style: Brace on new line Nit: Comment doesn't seem necessary, this is straightforward.
Brian Burg
Comment 4 2014-08-06 11:32:54 PDT
Committed r172162: <http://trac.webkit.org/changeset/172162>
Note You need to log in before you can comment on or make changes to this bug.