Bug 135651

Summary: [iOS] QuickLook returns an invalid MIME type for some documents
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=166855
https://bugs.webkit.org/show_bug.cgi?id=167453
Attachments:
Description Flags
Patch
none
Patch ddkilzer: review+

Andy Estes
Reported 2014-08-06 08:59:47 PDT
[iOS] QuickLook returns an invalid MIME type for some documents
Attachments
Patch (4.72 KB, patch)
2014-08-06 09:10 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (1.73 KB, patch)
2014-08-06 10:44 PDT, Andy Estes 		ddkilzer: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2014-08-06 09:00:55 PDT
<rdar://problem/17922339>
Andy Estes
Comment 2 2014-08-06 09:10:25 PDT
Created attachment 236106 [details] Patch
David Kilzer (:ddkilzer)
Comment 3 2014-08-06 09:46:13 PDT
Comment on attachment 236106 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236106&action=review r=me > Source/WebCore/platform/network/ios/QuickLook.mm:351 > + NSURLResponse *previewResponse = _quickLookHandle->nsResponse(); Should we use a RetainPtr<> here, or are we certain this object was retained and autoreleased before being returned?
Andy Estes
Comment 4 2014-08-06 10:22:03 PDT
(In reply to comment #3) > (From update of attachment 236106 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236106&action=review > > r=me Thanks! > > > Source/WebCore/platform/network/ios/QuickLook.mm:351 > > + NSURLResponse *previewResponse = _quickLookHandle->nsResponse(); > > Should we use a RetainPtr<> here, or are we certain this object was retained and autoreleased before being returned? QuickLookHandle is already storing the NSURLResponse returned by nsResponse() in a RetainPtr<>.
Andy Estes
Comment 5 2014-08-06 10:23:26 PDT
Committed r172151: <http://trac.webkit.org/changeset/172151>
Andy Estes
Comment 6 2014-08-06 10:44:46 PDT
Reopening to attach new patch.
Andy Estes
Comment 7 2014-08-06 10:44:47 PDT
Created attachment 236111 [details] Patch
David Kilzer (:ddkilzer)
Comment 8 2014-08-06 10:45:52 PDT
Comment on attachment 236111 [details] Patch r=me
Andy Estes
Comment 9 2014-08-06 11:18:56 PDT
Committed r172159: <http://trac.webkit.org/changeset/172159>
Note You need to log in before you can comment on or make changes to this bug.