| Summary: | [iOS] QuickLook returns an invalid MIME type for some documents | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ddkilzer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=166855 https://bugs.webkit.org/show_bug.cgi?id=167453 |
||||||||
| Attachments: |
|
||||||||
|
Description
Andy Estes
2014-08-06 08:59:47 PDT
Created attachment 236106 [details]
Patch
Comment on attachment 236106 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236106&action=review r=me > Source/WebCore/platform/network/ios/QuickLook.mm:351 > + NSURLResponse *previewResponse = _quickLookHandle->nsResponse(); Should we use a RetainPtr<> here, or are we certain this object was retained and autoreleased before being returned? (In reply to comment #3) > (From update of attachment 236106 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236106&action=review > > r=me Thanks! > > > Source/WebCore/platform/network/ios/QuickLook.mm:351 > > + NSURLResponse *previewResponse = _quickLookHandle->nsResponse(); > > Should we use a RetainPtr<> here, or are we certain this object was retained and autoreleased before being returned? QuickLookHandle is already storing the NSURLResponse returned by nsResponse() in a RetainPtr<>. Committed r172151: <http://trac.webkit.org/changeset/172151> Reopening to attach new patch. Created attachment 236111 [details]
Patch
Comment on attachment 236111 [details]
Patch
r=me
Committed r172159: <http://trac.webkit.org/changeset/172159> |