Bug 135633

Summary: setCustomSwipeViews inside didChangeBackForwardList client callback is ignored
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch sam: review+

Description Tim Horton 2014-08-05 19:21:06 PDT
WebKit clears the set of custom swipe views at the end of WebPageProxy::didChangeBackForwardList, *after* calling into the client. This means that if the client wants to setCustomSwipeViews in didChangeBackForwardList, it won't be respected.

Since there's only one client of this SPI, let's just stop clearing the list of custom swipe views in WebKit and leave that totally up to the client.
Comment 1 Radar WebKit Bug Importer 2014-08-05 19:21:15 PDT
<rdar://problem/17926507>
Comment 2 Tim Horton 2014-08-05 19:23:33 PDT
Created attachment 236072 [details]
patch
Comment 3 Tim Horton 2014-08-07 16:30:05 PDT
http://trac.webkit.org/changeset/172307