Bug 135618

Summary:

Web Inspector: rename protocol methods for getting replay session/segment data

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Brian Burg <burg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	timothy: review+

Description Brian Burg 2014-08-05 12:30:32 PDT

The Replay.json protocol commands currently mention serialization but these methods aren't actually used to serialize/deserialize recordings. 

(In a future patch I plan to implement serialization/deserialization, which will hand a big JSON string to the backend and get a session or segment back, or vice-versa. The frontend may or may not be involved in that, but in any case, these names are misleading)

Comment 1 Radar WebKit Bug Importer 2014-08-05 12:30:54 PDT

<rdar://problem/17920272>

Comment 2 Brian Burg 2014-08-05 12:59:09 PDT

Created attachment 236044 [details]
Patch

Comment 3 Brian Burg 2014-08-05 14:28:55 PDT

Committed r172080: <http://trac.webkit.org/changeset/172080>