Bug 135610

Summary: fast/ruby/ruby-svg-crash.html is flaky
Product: WebKit Reporter: Michal Pakula vel Rutka <mpakulavelrutka>
Component: DOMAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bjonesbe, commit-queue, hyatt, lucas.de.marchi, mmaxfield
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix none

Michal Pakula vel Rutka
Reported 2014-08-05 10:04:09 PDT
fast/ruby/ruby-svg-crash.html is flaky, when failing there is an additional line with right bracket in the output: @@ -1 +1,2 @@ -This succeeds if this test doesn't crash. +This succeeds if this test doesn't crash. +>
Attachments
proposed fix (3.16 KB, patch)
2014-12-31 18:44 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-12-31 12:53:07 PST
Same on Mac.
Alexey Proskuryakov
Comment 2 2014-12-31 18:44:26 PST
Created attachment 243855 [details] proposed fix This failure means that notifyDone() is called before the main test function executes. I'm not sure what exactly happens here. There are two possible mechanisms for the failure: 1. DOMContentLoaded fires substantially later than the inline script is executed. If parsing pauses right after </script>, that's quite possible. 2. Two chained zero-delay timers take longer than a 10 ms timer. I don't know if that's possible in WebCore.
WebKit Commit Bot
Comment 3 2015-01-01 00:04:08 PST
Comment on attachment 243855 [details] proposed fix Clearing flags on attachment: 243855 Committed r177842: <http://trac.webkit.org/changeset/177842>
WebKit Commit Bot
Comment 4 2015-01-01 00:04:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.