Bug 135597

Summary: Replace swap() methods on HashTable and related classes with std::swap()
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: NEW    
Severity: Normal CC: alecflett, benjamin, cmarcelo, commit-queue, esprehn+autocc, glenn, jamesr, japhet, jsbell, kangil.han, kondapallykalyan, luiz, mmaxfield, tonikitoo, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch bfulgham: review+

Zan Dobersek
Reported 2014-08-05 00:15:33 PDT
Replace swap() methods on HashTable and related classes with std::swap()
Attachments
Patch (33.76 KB, patch)
2014-08-05 00:29 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (33.73 KB, patch)
2014-08-05 00:39 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (35.77 KB, patch)
2014-08-05 11:25 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (36.33 KB, patch)
2014-08-06 06:55 PDT, Zan Dobersek 		bfulgham: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-08-05 00:29:02 PDT
Created attachment 236015 [details] Patch
WebKit Commit Bot
Comment 2 2014-08-05 00:31:43 PDT
Attachment 236015 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 3 2014-08-05 00:39:42 PDT
Created attachment 236016 [details] Patch
Zan Dobersek
Comment 4 2014-08-05 11:25:47 PDT
Created attachment 236036 [details] Patch
Zan Dobersek
Comment 5 2014-08-06 06:55:12 PDT
Created attachment 236099 [details] Patch
Brent Fulgham
Comment 6 2014-10-31 12:40:38 PDT
Comment on attachment 236099 [details] Patch What a great cleanup! It looks like the EFL failure is simply due to the EWS bot being in a bad state. r=me.
Alexey Proskuryakov
Comment 7 2014-10-31 15:01:16 PDT
Actually, looks like Efl bot complained about something related to this patch - it was in a bad state before, but not when it finished.
Zan Dobersek
Comment 8 2014-11-02 03:08:11 PST
Thanks for the review. The patch is outdated at this point, so I'll update it and also have a look at the failure on the EFL EWS.
Note You need to log in before you can comment on or make changes to this bug.