| Summary: | Replace swap() methods on HashTable and related classes with std::swap() | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||||||
| Status: | NEW --- | ||||||||||||
| Severity: | Normal | CC: | alecflett, benjamin, cmarcelo, commit-queue, esprehn+autocc, glenn, jamesr, japhet, jsbell, kangil.han, kondapallykalyan, luiz, mmaxfield, tonikitoo, WebkitBugTracker | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Zan Dobersek
2014-08-05 00:15:33 PDT
Created attachment 236015 [details]
Patch
Attachment 236015 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 28 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 236016 [details]
Patch
Created attachment 236036 [details]
Patch
Created attachment 236099 [details]
Patch
Comment on attachment 236099 [details]
Patch
What a great cleanup! It looks like the EFL failure is simply due to the EWS bot being in a bad state. r=me.
Actually, looks like Efl bot complained about something related to this patch - it was in a bad state before, but not when it finished. Thanks for the review. The patch is outdated at this point, so I'll update it and also have a look at the failure on the EFL EWS. |