Bug 135585

Summary: [GTK] [CSS Shapes] Layout test fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html fails
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: bjonesbe, cgarcia, commit-queue, dino, jfernandez, mrobinson, pnormand, rego
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Carlos Alberto Lopez Perez 2014-08-04 17:34:19 PDT 
The layout test fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html added on r172010 <http://trac.webkit.org/changeset/172010> fails on GTK:

fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html [ ImageOnlyFailure ]

Failure: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r172010%20%281886%29/fast/shapes/shape-outside-floats/shape-outside-image-shape-margin-diffs.html
Comment 1 Carlos Alberto Lopez Perez 2014-08-04 18:24:15 PDT 
I have added this test to the list of expected failures for GTK on https://trac.webkit.org/r172017. Please remove it from the list if you fix the issue. Thanks
Comment 2 Bem Jones-Bey 2014-08-05 13:44:34 PDT 
Created attachment 236045 [details]
Patch

This should fix the issue, but I have not been able to test it on a GTK build yet, if someone can do that, it would be great, otherwise I'll update when I have a working Linux GTK build.
Comment 3 Bem Jones-Bey 2014-08-05 15:35:52 PDT 
Comment on attachment 236045 [details]
Patch

This does fix it in my GTK build.
Comment 4 Carlos Alberto Lopez Perez 2014-08-05 16:34:38 PDT 
(In reply to comment #3)
> (From update of attachment 236045 [details])
> This does fix it in my GTK build.

Yes. I confirm that this patch fixes the issue on the GTK build.

I'm not a reviewer, but hopefully one will look into it soon :)

Thanks
Comment 5 Zoltan Horvath 2014-08-05 17:48:53 PDT 
Comment on attachment 236045 [details]
Patch

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 236045 [details] [details])
> > This does fix it in my GTK build.
> 
> Yes. I confirm that this patch fixes the issue on the GTK build.
> 
> I'm not a reviewer, but hopefully one will look into it soon :)
> 
> Thanks

Thanks for checking!
Comment 6 WebKit Commit Bot 2014-08-05 18:30:44 PDT 
Comment on attachment 236045 [details]
Patch

Clearing flags on attachment: 236045

Committed r172116: <http://trac.webkit.org/changeset/172116>
Comment 7 WebKit Commit Bot 2014-08-05 18:30:48 PDT 
All reviewed patches have been landed.  Closing bug.