Bug 135554

Summary: Enable didReceiveDataArray callback on Mac
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: PlatformAssignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, psolanki
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 135727    
Bug Blocks:    
Attachments:
Description Flags
Patch for bots
none
Patch kling: review+

Pratik Solanki
Reported 2014-08-03 22:15:40 PDT
iOS uses didReceiveDataArray callback while Mac uses didReceiveData. It would be nice to make the two platforms consistent. didReceiveDataArray callback is better since it reduces a copying phase in CFNetwork. <rdar://problem/9170731>
Attachments
Patch for bots (1.34 KB, patch)
2014-08-03 22:19 PDT, Pratik Solanki 		no flags
DetailsFormatted DiffDiff
Patch (1.47 KB, patch)
2014-08-07 19:57 PDT, Pratik Solanki 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2014-08-03 22:19:50 PDT
Created attachment 235960 [details] Patch for bots
Pratik Solanki
Comment 2 2014-08-07 15:10:12 PDT
Uncovered bug 135727 when looking at the memory impact of this change.
Pratik Solanki
Comment 3 2014-08-07 19:57:32 PDT
Created attachment 236255 [details] Patch
Andreas Kling
Comment 4 2014-08-08 14:30:28 PDT
Comment on attachment 236255 [details] Patch r=me
Pratik Solanki
Comment 5 2014-08-11 12:21:35 PDT
Thanks for the review. I'll check this in after bug 135727.
Pratik Solanki
Comment 6 2014-08-12 16:46:08 PDT
Committed r172508: <http://trac.webkit.org/changeset/172508>
Note You need to log in before you can comment on or make changes to this bug.