Bug 135554

Summary: Enable didReceiveDataArray callback on Mac
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: PlatformAssignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, psolanki
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 135727    
Bug Blocks:    
Attachments:
Description Flags
Patch for bots
none
Patch kling: review+

Description Pratik Solanki 2014-08-03 22:15:40 PDT 
iOS uses didReceiveDataArray callback while Mac uses didReceiveData. It would be nice to make the two platforms consistent. didReceiveDataArray callback is better since it reduces a copying phase in CFNetwork.

<rdar://problem/9170731>
Comment 1 Pratik Solanki 2014-08-03 22:19:50 PDT 
Created attachment 235960 [details]
Patch for bots
Comment 2 Pratik Solanki 2014-08-07 15:10:12 PDT 
Uncovered bug 135727 when looking at the memory impact of this change.
Comment 3 Pratik Solanki 2014-08-07 19:57:32 PDT 
Created attachment 236255 [details]
Patch
Comment 4 Andreas Kling 2014-08-08 14:30:28 PDT 
Comment on attachment 236255 [details]
Patch

r=me
Comment 5 Pratik Solanki 2014-08-11 12:21:35 PDT 
Thanks for the review. I'll check this in after bug 135727.
Comment 6 Pratik Solanki 2014-08-12 16:46:08 PDT 
Committed r172508: <http://trac.webkit.org/changeset/172508>