Bug 135523

Summary: Add some structure related assertions
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch ggaren: review+

Mark Lam
Reported 2014-08-01 15:33:46 PDT
Adding 2 assertions: 1. assert that we don't index pass the end of the StructureIDTable. This should never happen, but this assertion will help catch bugs where a bad structureID gets passed in. 2. assert that cells in MarkedBlock::callDestructor() that are not zapped should have a non-null StructureID. This will help us catch bugs where the other cell header flag bits get set after the cell is zapped, thereby making the cell look like an unzapped cell but has a null structureID.
Attachments
the patch (2.23 KB, patch)
2014-08-01 15:38 PDT, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-08-01 15:38:16 PDT
Created attachment 235910 [details] the patch
Geoffrey Garen
Comment 2 2014-08-01 15:41:05 PDT
Comment on attachment 235910 [details] the patch r=me
Mark Lam
Comment 3 2014-08-01 15:50:50 PDT
Thanks. Landed in r171953: <http://trac.webkit.org/r171953>.
Note You need to log in before you can comment on or make changes to this bug.