Bug 135523

Summary:

Add some structure related assertions

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch	ggaren: review+

Description Mark Lam 2014-08-01 15:33:46 PDT

Adding 2 assertions:
1. assert that we don't index pass the end of the StructureIDTable.  This should never happen, but this assertion will help catch bugs where a bad structureID gets passed in.
2. assert that cells in MarkedBlock::callDestructor() that are not zapped should have a non-null StructureID.  This will help us catch bugs where the other cell header flag bits get set after the cell is zapped, thereby making the cell look like an unzapped cell but has a null structureID.

Comment 1 Mark Lam 2014-08-01 15:38:16 PDT

Created attachment 235910 [details]
the patch

Comment 2 Geoffrey Garen 2014-08-01 15:41:05 PDT

Comment on attachment 235910 [details]
the patch

r=me

Comment 3 Mark Lam 2014-08-01 15:50:50 PDT

Thanks.  Landed in r171953: <http://trac.webkit.org/r171953>.