Web Inspector: message dispatch metrics should use high-resolution timing data

• Component: Web Inspector
• Status: RESOLVED FIXED

[Brian Burg]

in particular, things controlled by InspectorBackend.dumpInspectorTimeStats

[Radar WebKit Bug Importer]

<rdar://problem/17874162>

[BJ Burg]

Created attachment 259888 [details]
Proposed Fix

[Joseph Pecoraro]

Comment on attachment 259888 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=259888&action=review

Looks good to me. cq- so you don't enable it by default.

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:44
> -        this.dumpInspectorTimeStats = false;
> +        this.dumpInspectorTimeStats = true;
>          this.dumpInspectorProtocolMessages = false;
> -        this.warnForLongMessageHandling = false;
> +        this.warnForLongMessageHandling = true;

I don't think you want to commit these.

Note, you could write a test for these if you wanted. You would just enable these dump/warn flags at the start then trigger some messages. But I'm not sure that would be too valuable.

[Joseph Pecoraro]

I wonder how our jsmin.py is doing minifying with new syntax (template strings, arrow functions, etc). I wonder if the first time we have a newline in a template string if we will run into issues.

[Build Bot]

Comment on attachment 259888 [details]
Proposed Fix

Attachment 259888 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/106488

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 259894 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[BJ Burg]

(In reply to comment #4)
> I wonder how our jsmin.py is doing minifying with new syntax (template
> strings, arrow functions, etc). I wonder if the first time we have a newline
> in a template string if we will run into issues.

We already have some, I think.

[Build Bot]

Comment on attachment 259888 [details]
Proposed Fix

Attachment 259888 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/106480

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 259896 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[BJ Burg]

Created attachment 259897 [details]
Proposed Fix

[Timothy Hatcher]

Comment on attachment 259888 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=259888&action=review

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:1129
> +function timestampMS()

Just timestamp()?

> Source/WebInspectorUI/UserInterface/Protocol/MessageDispatcher.js:68
> -    if (this._dispatchTimeout)
> +    if (WebInspector._dispatchTimeout)

I think we should use this. The other places should change.

[BJ Burg]

Committed r188946: <http://trac.webkit.org/changeset/188946>