Bug 135417

Summary:

[Linux] Resource leak of unclosed file descriptor - when open returns zero, descriptor handle leaks.

Product:

WebKit

Reporter:

przemeks@pkuczynski.com <p.kuczynski>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gyuyoung.kim, m.leszko, mpakulavelrutka

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none

Description przemeks@pkuczynski.com 2014-07-30 07:04:41 PDT

When open returns zero, fd handle leaks. Checking (fd > 0) needs to be replaced
with (fd != -1).

Comment 1 przemeks@pkuczynski.com 2014-07-30 07:39:52 PDT

Created attachment 235744 [details]
proposed patch

Comment 2 Gyuyoung Kim 2014-07-31 01:38:58 PDT

CC'ing Filip.

Comment 3 WebKit Commit Bot 2014-08-05 18:03:12 PDT

Comment on attachment 235744 [details]
proposed patch

Clearing flags on attachment: 235744

Committed r172113: <http://trac.webkit.org/changeset/172113>

Comment 4 WebKit Commit Bot 2014-08-05 18:03:17 PDT

All reviewed patches have been landed.  Closing bug.