Bug 135415

Summary:

Rename 'result' character-position pointers to 'current' in CSSParser

Product:

WebKit

Reporter:

Martin Hodovan <mhodovan.u-szeged>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

darin, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	ossy: review-, ossy: commit-queue-

Martin Hodovan

Reported 2014-07-30 02:53:49 PDT

Using the names 'result' and 'dest' for a pointer to the next character to be parsed is confusing in this context. This should be replaced with the name 'current'.

Attachments
Proposed patch (19.84 KB, patch) 2014-07-30 03:00 PDT, Martin Hodovan	ossy: review- ossy: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Martin Hodovan

Comment 1 2014-07-30 03:00:49 PDT

Created attachment 235739 [details] Proposed patch

Darin Adler

Comment 2 2014-07-30 10:43:41 PDT

Comment on attachment 235739 [details] Proposed patch I don’t think this is an improvement. In a function that both reads and writes, it’s confusing to have a variable named “current” that is the pointer to the next place to write. Sounds like it could be the next byte to read too. So result may be bad, but I don’t think current is better, at least in some of these functions.

Note You need to log in before you can comment on or make changes to this bug.