| Summary: | [css-grid] fast/css-grid-layout/grid-element-shrink-to-fit.html fails on Retina machines | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
| Component: | Tools / Tests | Assignee: | zalan <zalan> | ||||
| Status: | ASSIGNED --- | ||||||
| Severity: | Normal | CC: | ahmad.saleem792, ben_schwartz, jfernandez, rego, sgill26, svillar, zalan | ||||
| Priority: | P2 | Keywords: | LayoutTestFailure | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Proskuryakov
2014-07-29 16:29:14 PDT
Created attachment 235715 [details]
the diff
I don't get why you attach that diff as this is not a pixel test. Could you provide the text differences you get? (In reply to comment #2) > I don't get why you attach that diff as this is not a pixel test. Could you provide the text differences you get? Beh forget about it, I thought the test was a regular checkLayout() test, but that was Blink not WebKit. it looks like a subpixel alignment issue to me. This fails at an odd combination. It works fine both on retina and non-retina displays, but when forcing non-retina device scale on a retina screen, some boxes get sized incorrectly. This was migrated to WPT by Blink / Chromium here - https://github.com/web-platform-tests/wpt/commit/1ab0f90bff15877f3749687d615f4ec34053e840 We can delete this local copy now. We pass WPT variant - https://wpt.fyi/results/css/css-grid/grid-model/grid-size-shrink-to-fit-001.html?label=master&label=experimental&aligned&q=grid-size-shrink-to-fit-001.html wpt.fyi results wouldn't be doing the same thing of running in a 1x window on a 2x device. But looks like our test is actually now passing. |