Bug 135404

Summary: [css-grid] fast/css-grid-layout/grid-element-shrink-to-fit.html fails on Retina machines
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: alan <zalan>
Status: ASSIGNED    
Severity: Normal CC: ahmad.saleem792, ben_schwartz, jfernandez, rego, sgill26, svillar, zalan
Priority: P2 Keywords: LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the diff none

Alexey Proskuryakov
Reported 2014-07-29 16:29:14 PDT
fast/css-grid-layout/grid-element-shrink-to-fit.html always fails for me in WK2 mode on my Retina MacBook Pro.
Attachments
the diff (9.04 KB, image/png)
2014-07-29 16:30 PDT, Alexey Proskuryakov 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-07-29 16:30:28 PDT
Created attachment 235715 [details] the diff
Sergio Villar Senin
Comment 2 2014-07-30 01:31:41 PDT
I don't get why you attach that diff as this is not a pixel test. Could you provide the text differences you get?
Sergio Villar Senin
Comment 3 2014-07-30 01:43:12 PDT
(In reply to comment #2) > I don't get why you attach that diff as this is not a pixel test. Could you provide the text differences you get? Beh forget about it, I thought the test was a regular checkLayout() test, but that was Blink not WebKit.
alan
Comment 4 2014-07-31 20:20:15 PDT
it looks like a subpixel alignment issue to me.
alan
Comment 5 2014-08-01 09:08:46 PDT
This fails at an odd combination. It works fine both on retina and non-retina displays, but when forcing non-retina device scale on a retina screen, some boxes get sized incorrectly.
Alexey Proskuryakov
Comment 7 2024-07-08 16:33:21 PDT
wpt.fyi results wouldn't be doing the same thing of running in a 1x window on a 2x device. But looks like our test is actually now passing.
Note You need to log in before you can comment on or make changes to this bug.