Summary: | Web Inspector: Incorrectly sized TimelineDataGrid event bubble | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2014-07-28 16:57:12 PDT
Created attachment 235645 [details]
[IMAGE] Issue
Created attachment 235646 [details]
[IMAGE] Expected
This is happening because in TimelineDataGridNode.prototype.refreshGraph the visibleWidth is 0. That is scary, because it will almost always happen before elements are added at the graph refreshed. It is just using that to calculate the secondsPerPixel, including doing an offsetWidth per-datagridnode. We can eliminate this possible forced layout, as well as the calculation because the graph data source must already know the secondsPerPixel! Patch coming. Created attachment 235657 [details]
[PATCH] Proposed Fix
Comment on attachment 235657 [details]
[PATCH] Proposed Fix
Awesome!
Comment on attachment 235657 [details] [PATCH] Proposed Fix Clearing flags on attachment: 235657 Committed r171721: <http://trac.webkit.org/changeset/171721> All reviewed patches have been landed. Closing bug. |