RESOLVED FIXED 135371
Web Inspector: Incorrectly sized TimelineDataGrid event bubble 
https://bugs.webkit.org/show_bug.cgi?id=135371
Summary Web Inspector: Incorrectly sized TimelineDataGrid event bubble
Joseph Pecoraro
Reported 2014-07-28 16:57:12 PDT
* SUMMARY Sometimes there are incorrectly sized TimelineDataGrid event bubbles in the overview view. This is misleading. See attached screenshots. * STEPS TO REPRODUCE 1. Inspect daringfireball.net 2. Click Timelines 3. Select a time range of about 0-200ms 4. Reload the page (should show some stuff, but there should be JS evaluation after the current selection range) 5. Select a time range of about 300ms-2000ms => script bubble is much larger than expected
Attachments
[IMAGE] Issue (82.26 KB, image/png)
2014-07-28 17:00 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] Expected (82.45 KB, image/png)
2014-07-28 17:01 PDT, Joseph Pecoraro 		no flags
Details
[PATCH] Proposed Fix (2.80 KB, patch)
2014-07-28 19:41 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-07-28 16:57:38 PDT
<rdar://problem/17836658>
Joseph Pecoraro
Comment 2 2014-07-28 17:00:55 PDT
Created attachment 235645 [details] [IMAGE] Issue
Joseph Pecoraro
Comment 3 2014-07-28 17:01:14 PDT
Created attachment 235646 [details] [IMAGE] Expected
Joseph Pecoraro
Comment 4 2014-07-28 19:33:55 PDT
This is happening because in TimelineDataGridNode.prototype.refreshGraph the visibleWidth is 0. That is scary, because it will almost always happen before elements are added at the graph refreshed. It is just using that to calculate the secondsPerPixel, including doing an offsetWidth per-datagridnode. We can eliminate this possible forced layout, as well as the calculation because the graph data source must already know the secondsPerPixel! Patch coming.
Joseph Pecoraro
Comment 5 2014-07-28 19:41:26 PDT
Created attachment 235657 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 6 2014-07-28 20:45:55 PDT
Comment on attachment 235657 [details] [PATCH] Proposed Fix Awesome!
WebKit Commit Bot
Comment 7 2014-07-28 21:18:05 PDT
Comment on attachment 235657 [details] [PATCH] Proposed Fix Clearing flags on attachment: 235657 Committed r171721: <http://trac.webkit.org/changeset/171721>
WebKit Commit Bot
Comment 8 2014-07-28 21:18:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.