| Summary: | Text-shadow with (0, 0) offset and radius = 0 is ugly | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dino, esprehn+autocc, glenn, jonlee, kondapallykalyan, mark.lam, mitz, simon.fraser, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Myles C. Maxfield
2014-07-28 15:00:47 PDT
Created attachment 235620 [details]
Patch
Comment on attachment 235620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235620&action=review > Source/WebCore/rendering/TextPainter.cpp:68 > + const auto& shadow = *shadowPtr; > + return shadow.location() == IntPoint() && !shadow.radius(); Seems a little strange to have this local variable just so we can use "." in two places instead of "->". > Source/WebCore/rendering/TextPainter.cpp:84 > + if (shadow && !shadowIsEmpty) No need to null check shadow here since isEmptyShadow already null checks it. This caused a build failure: http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20%28Build%29/builds/9771/steps/compile-webkit/logs/stdio (In reply to comment #5) > This caused a build failure: > http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20%28Build%29/builds/9771/steps/compile-webkit/logs/stdio Fixed in http://trac.webkit.org/changeset/172156. (In reply to comment #4) > http://trac.webkit.org/changeset/172153 This caused bug 136612. |