Bug 135357

Summary: Text-shadow with (0, 0) offset and radius = 0 is ugly
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, esprehn+autocc, glenn, jonlee, kondapallykalyan, mark.lam, mitz, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Myles C. Maxfield
Reported 2014-07-28 15:00:47 PDT
Text-shadow with (0, 0) offset and radius = 0 is ugly
Attachments
Patch (4.42 KB, patch)
2014-07-28 15:04 PDT, Myles C. Maxfield 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-07-28 15:04:10 PDT
Created attachment 235620 [details] Patch
Myles C. Maxfield
Comment 2 2014-07-28 15:04:36 PDT
<rdar://problem/15000806>
Darin Adler
Comment 3 2014-08-05 16:58:04 PDT
Comment on attachment 235620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235620&action=review > Source/WebCore/rendering/TextPainter.cpp:68 > + const auto& shadow = *shadowPtr; > + return shadow.location() == IntPoint() && !shadow.radius(); Seems a little strange to have this local variable just so we can use "." in two places instead of "->". > Source/WebCore/rendering/TextPainter.cpp:84 > + if (shadow && !shadowIsEmpty) No need to null check shadow here since isEmptyShadow already null checks it.
Myles C. Maxfield
Comment 4 2014-08-06 10:36:39 PDT
http://trac.webkit.org/changeset/172153
mitz
Comment 7 2014-09-07 12:47:24 PDT
(In reply to comment #4) > http://trac.webkit.org/changeset/172153 This caused bug 136612.
Note You need to log in before you can comment on or make changes to this bug.