Bug 135353

Summary:

Use CSS3 Decorating Box concept to determine thickness for text decorations

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

NEW ---

Severity:

Normal

CC:

commit-queue, dino, esprehn+autocc, glenn, je_julie.kim, jonlee, kondapallykalyan, martin.schaus, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=230083

Attachments:

Description	Flags
Patch	mmaxfield: review-

Description Myles C. Maxfield 2014-07-28 14:19:53 PDT

Use CSS3 Decorating Box concept to determine thickness for text decorations

Comment 1 Myles C. Maxfield 2014-07-28 14:37:46 PDT

Created attachment 235617 [details]
Patch

Comment 2 Myles C. Maxfield 2014-07-28 14:40:11 PDT

<rdar://problem/15044440>

Comment 3 Myles C. Maxfield 2014-09-08 19:59:40 PDT

Comment on attachment 235617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235617&action=review

> Source/WebCore/rendering/InlineTextBox.h:187
> +    const InlineFlowBox* m_decoratingBox;

This blows up the size by a significant amount. See if the performance hit of computing this when it is needed is too high.

Comment 4 Myles C. Maxfield 2022-04-04 14:22:28 PDT

*** Bug 167331 has been marked as a duplicate of this bug. ***

Comment 5 Myles C. Maxfield 2022-04-04 14:23:03 PDT

*** Bug 190772 has been marked as a duplicate of this bug. ***

Comment 6 Myles C. Maxfield 2022-07-16 20:18:05 PDT

*** Bug 130657 has been marked as a duplicate of this bug. ***