Bug 135344

Summary: REGRESSION (r160806): CSS zoom property doesn't work on anything inside anchors.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2 Keywords: InRadar, Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andreas Kling
Reported 2014-07-28 11:43:23 PDT
<rdar://problem/17759577>
Attachments
Patch (3.83 KB, patch)
2014-07-28 11:59 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (3.92 KB, patch)
2014-07-28 12:07 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-07-28 11:59:59 PDT
Created attachment 235603 [details] Patch
WebKit Commit Bot
Comment 2 2014-07-28 12:01:32 PDT
Attachment 235603 [details] did not pass style-queue: ERROR: LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2014-07-28 12:07:36 PDT
Created attachment 235604 [details] Patch
Simon Fraser (smfr)
Comment 4 2014-07-28 12:18:20 PDT
Comment on attachment 235604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235604&action=review > Source/WebCore/rendering/style/RenderStyle.h:2087 > { > + setEffectiveZoom(effectiveZoom() * f); > if (compareEqual(visual->m_zoom, f)) > return false; > visual.access()->m_zoom = f; > - setEffectiveZoom(effectiveZoom() * zoom()); > return true; Would be nice to rename "f" to something understandable.
WebKit Commit Bot
Comment 5 2014-07-28 13:45:08 PDT
Comment on attachment 235604 [details] Patch Clearing flags on attachment: 235604 Committed r171692: <http://trac.webkit.org/changeset/171692>
WebKit Commit Bot
Comment 6 2014-07-28 13:45:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.