Bug 135310

Summary: Parent fullscreen from window instead of view
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: WebKit2Assignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, jer.noble, philipj, sergio, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
jer.noble: review+
Patch for landing. none

Description Jeremy Jones 2014-07-25 16:14:26 PDT 
'parent fullscren from window instead of view
Comment 1 Jeremy Jones 2014-07-25 16:19:05 PDT 
Created attachment 235550 [details]
Patch
Comment 2 Jeremy Jones 2014-07-25 16:20:24 PDT 
Created attachment 235551 [details]
Patch
Comment 3 Jeremy Jones 2014-07-25 16:23:44 PDT 
<rdar://problem/17782407>
Comment 4 Jer Noble 2014-07-25 16:36:59 PDT 
Comment on attachment 235551 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235551&action=review

> Source/WebKit/mac/ChangeLog:7
> +        Reviewed by NOBODY (OOPS!).
> +

This and...

> Source/WebKit2/ChangeLog:7
> +        Reviewed by NOBODY (OOPS!).
> +

...this could use an explanation about why switching from view-parented to window-parented fixes the rotation problem.

Other than that, looks good.
Comment 5 Jeremy Jones 2014-07-25 16:42:41 PDT 
Created attachment 235553 [details]
Patch for landing.
Comment 6 Jeremy Jones 2014-07-25 16:47:22 PDT 
This also needs a WK2 reviewer.
Comment 7 WebKit Commit Bot 2014-07-25 17:43:37 PDT 
Comment on attachment 235553 [details]
Patch for landing.

Clearing flags on attachment: 235553

Committed r171635: <http://trac.webkit.org/changeset/171635>