Bug 135273

Summary: [iOS] REGRESSION (WebKit2): Can't login to Wordpress.com, facebook.com when always allowing cookies
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit2Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, ddkilzer, mhock, psolanki
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

Description Daniel Bates 2014-07-24 17:07:42 PDT 
When allowing all cookies, some sites may not behave correctly, including Facebook.com.
Comment 1 Daniel Bates 2014-07-24 17:07:57 PDT 
<rdar://problem/17598815>
Comment 2 Daniel Bates 2014-07-24 17:10:26 PDT 
Created attachment 235475 [details]
Patch
Comment 3 Alexey Proskuryakov 2014-07-24 17:12:45 PDT 
Comment on attachment 235475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235475&action=review

> Source/WebCore/ChangeLog:5
> +        https://bugs.webkit.org/show_bug.cgi?id=135273

Please add a Radar link here too.

> Source/WebCore/ChangeLog:11
> +        Currently, when we update the CRURLRequest object associated with a ResourceRequest object

Typo: should be CFURLRequest.
Comment 4 Daniel Bates 2014-07-24 17:13:33 PDT 
Comment on attachment 235475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235475&action=review

>> Source/WebCore/ChangeLog:5
>> +        https://bugs.webkit.org/show_bug.cgi?id=135273
> 
> Please add a Radar link here too.

Will do before landing.

>> Source/WebCore/ChangeLog:11
>> +        Currently, when we update the CRURLRequest object associated with a ResourceRequest object
> 
> Typo: should be CFURLRequest.

Will substitute CFURLRequest for CRURLRequest before landing.
Comment 5 Daniel Bates 2014-07-24 17:15:40 PDT 
Committed r171559: <http://trac.webkit.org/changeset/171559>