Bug 135264

Summary: Crash when measuring a glyphs from a fallback SVG font
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jonlee, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Description Myles C. Maxfield 2014-07-24 16:02:24 PDT
Crash when measuring a glyphs from a fallback SVG font
Comment 1 Myles C. Maxfield 2014-07-24 17:10:39 PDT
Created attachment 235476 [details]
Patch
Comment 2 Myles C. Maxfield 2014-07-24 17:13:03 PDT
<rdar://problem/16591706>
Comment 3 Simon Fraser (smfr) 2014-07-24 17:13:54 PDT
Comment on attachment 235476 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235476&action=review

> Source/WebCore/platform/graphics/WidthIterator.cpp:127
> +        if (iterator.run().renderingContext() && typesettingFeatures & Kerning) {

Minor preference for parens around (typesettingFeatures & Kerning)

> Source/WebCore/platform/graphics/WidthIterator.cpp:129
> +            // However, doing the above FIXME seems like questionable design. Perhaps a larger refactoring of SVG fonts is necessary.

Odd comment in this context. Just reword the FIXME.
Comment 4 Myles C. Maxfield 2014-07-24 17:29:51 PDT
https://trac.webkit.org/r171561