Bug 135264 - Crash when measuring a glyphs from a fallback SVG font
Summary: Crash when measuring a glyphs from a fallback SVG font
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-24 16:02 PDT by Myles C. Maxfield
Modified: 2014-07-24 17:30 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.14 KB, patch)
2014-07-24 17:10 PDT, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-07-24 16:02:24 PDT 
Crash when measuring a glyphs from a fallback SVG font
Comment 1 Myles C. Maxfield 2014-07-24 17:10:39 PDT 
Created attachment 235476 [details]
Patch
Comment 2 Myles C. Maxfield 2014-07-24 17:13:03 PDT 
<rdar://problem/16591706>
Comment 3 Simon Fraser (smfr) 2014-07-24 17:13:54 PDT 
Comment on attachment 235476 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235476&action=review

> Source/WebCore/platform/graphics/WidthIterator.cpp:127
> +        if (iterator.run().renderingContext() && typesettingFeatures & Kerning) {

Minor preference for parens around (typesettingFeatures & Kerning)

> Source/WebCore/platform/graphics/WidthIterator.cpp:129
> +            // However, doing the above FIXME seems like questionable design. Perhaps a larger refactoring of SVG fonts is necessary.

Odd comment in this context. Just reword the FIXME.
Comment 4 Myles C. Maxfield 2014-07-24 17:29:51 PDT 
https://trac.webkit.org/r171561