Bug 135259 – Mac long-press feature flag

• Component: UI Events
• Status: RESOLVED FIXED

[Peyton Randolph]

I'd like to rename the LINK_LONG_PRESS feature flag to MAC_LONG_PRESS to reflect that the long press gesture is not just for links.

[Peyton Randolph]

Created attachment 235465 [details]
Patch

[Beth Dakin]

Comment on attachment 235465 [details]
Patch

I'm not crazy about using a platform name in this enable flag. LONG_PRESS seems like it should be sufficient. However, Peyton says that the implementation he has planned will be very Mac specific and reliant upon AppKit features. So I suppose this name is good for now, given that plan. We can always change it.

[WebKit Commit Bot]

Comment on attachment 235465 [details]
Patch

Rejecting attachment 235465 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 235465 [details]
Patch

Clearing flags on attachment: 235465

Committed r171557: <http://trac.webkit.org/changeset/171557>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Fraser (smfr)]

I don't think having MAC_ in the name is a good idea.