Bug 135259 - Mac long-press feature flag
Summary: Mac long-press feature flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Other
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 135257
  Show dependency treegraph
 
Reported: 2014-07-24 14:39 PDT by Peyton Randolph
Modified: 2014-07-24 17:42 PDT (History)
4 users (show)

See Also:


Attachments
Patch (31.85 KB, patch)
2014-07-24 14:44 PDT, Peyton Randolph
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peyton Randolph 2014-07-24 14:39:19 PDT
I'd like to rename the LINK_LONG_PRESS feature flag to MAC_LONG_PRESS to reflect that the long press gesture is not just for links.
Comment 1 Peyton Randolph 2014-07-24 14:44:23 PDT
Created attachment 235465 [details]
Patch
Comment 2 Beth Dakin 2014-07-24 16:13:13 PDT
Comment on attachment 235465 [details]
Patch

I'm not crazy about using a platform name in this enable flag. LONG_PRESS seems like it should be sufficient. However, Peyton says that the implementation he has planned will be very Mac specific and reliant upon AppKit features. So I suppose this name is good for now, given that plan. We can always change it.
Comment 3 WebKit Commit Bot 2014-07-24 16:17:24 PDT
Comment on attachment 235465 [details]
Patch

Rejecting attachment 235465 [details] from commit-queue.

prandolph@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 4 WebKit Commit Bot 2014-07-24 16:50:38 PDT
Comment on attachment 235465 [details]
Patch

Clearing flags on attachment: 235465

Committed r171557: <http://trac.webkit.org/changeset/171557>
Comment 5 WebKit Commit Bot 2014-07-24 16:50:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Simon Fraser (smfr) 2014-07-24 17:42:08 PDT
I don't think having MAC_ in the name is a good idea.