Bug 135199

Summary: [Win] Use NO_RETURN_DUE_TO_CRASH on Windows
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: JavaScriptCoreAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cmarcelo, commit-queue, d-r, fmalita, fpizlo, gyuyoung.kim, mark.lam, pdr, schenney, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch mark.lam: review+

Brent Fulgham
Reported 2014-07-23 09:18:12 PDT
The NO_RETURN_DUE_TO_CRASH macro is defined for Clang as NO_RETURN. We have a NO_RETURN implementation on Windows; let's use it! This patch activates NO_RETURN_DUE_TO_CRASH, and makes sure the declaration is made in the appropriate part of the function call to satisfy the MSVC compiler.
Attachments
Patch (5.49 KB, patch)
2014-07-23 09:30 PDT, Brent Fulgham 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-07-23 09:30:25 PDT
Created attachment 235354 [details] Patch
Mark Lam
Comment 2 2014-07-23 09:50:42 PDT
Comment on attachment 235354 [details] Patch r=me
Brent Fulgham
Comment 3 2014-07-23 11:19:15 PDT
Committed r171482: <http://trac.webkit.org/changeset/171482>
Note You need to log in before you can comment on or make changes to this bug.