Bug 135199 - [Win] Use NO_RETURN_DUE_TO_CRASH on Windows
Summary: [Win] Use NO_RETURN_DUE_TO_CRASH on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-23 09:18 PDT by Brent Fulgham
Modified: 2014-07-23 11:19 PDT (History)
12 users (show)

See Also:


Attachments
Patch (5.49 KB, patch)
2014-07-23 09:30 PDT, Brent Fulgham
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-07-23 09:18:12 PDT
The NO_RETURN_DUE_TO_CRASH macro is defined for Clang as NO_RETURN. We have a NO_RETURN implementation on Windows; let's use it!

This patch activates NO_RETURN_DUE_TO_CRASH, and makes sure the declaration is made in the appropriate part of the function call to satisfy the MSVC compiler.
Comment 1 Brent Fulgham 2014-07-23 09:30:25 PDT
Created attachment 235354 [details]
Patch
Comment 2 Mark Lam 2014-07-23 09:50:42 PDT
Comment on attachment 235354 [details]
Patch

r=me
Comment 3 Brent Fulgham 2014-07-23 11:19:15 PDT
Committed r171482: <http://trac.webkit.org/changeset/171482>