WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
135199
[Win] Use NO_RETURN_DUE_TO_CRASH on Windows
https://bugs.webkit.org/show_bug.cgi?id=135199
Summary
[Win] Use NO_RETURN_DUE_TO_CRASH on Windows
Brent Fulgham
Reported
2014-07-23 09:18:12 PDT
The NO_RETURN_DUE_TO_CRASH macro is defined for Clang as NO_RETURN. We have a NO_RETURN implementation on Windows; let's use it! This patch activates NO_RETURN_DUE_TO_CRASH, and makes sure the declaration is made in the appropriate part of the function call to satisfy the MSVC compiler.
Attachments
Patch
(5.49 KB, patch)
2014-07-23 09:30 PDT
,
Brent Fulgham
mark.lam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2014-07-23 09:30:25 PDT
Created
attachment 235354
[details]
Patch
Mark Lam
Comment 2
2014-07-23 09:50:42 PDT
Comment on
attachment 235354
[details]
Patch r=me
Brent Fulgham
Comment 3
2014-07-23 11:19:15 PDT
Committed
r171482
: <
http://trac.webkit.org/changeset/171482
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug