Bug 135185

Summary: Migrate accessibility/ to using nullptr instead of 0
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dino, dmazzoni, jcraig, jdiggs, jonlee, mario, samuel_white, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Myles C. Maxfield
Reported 2014-07-22 19:08:29 PDT
Migrate accessibility/ to using nullptr instead of 0
Attachments
Patch (97.26 KB, patch)
2014-07-22 19:09 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-07-22 19:09:26 PDT
Created attachment 235337 [details] Patch
WebKit Commit Bot
Comment 2 2014-07-22 19:11:58 PDT
Attachment 235337 [details] did not pass style-queue: ERROR: Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.h:52: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/accessibility/AccessibilityObject.cpp:2214: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 2 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Myles C. Maxfield
Comment 3 2014-07-22 19:16:48 PDT
The style comments are false negatives.
Simon Fraser (smfr)
Comment 4 2014-07-22 22:34:35 PDT
Comment on attachment 235337 [details] Patch rs=me
WebKit Commit Bot
Comment 5 2014-07-23 07:57:35 PDT
Comment on attachment 235337 [details] Patch Clearing flags on attachment: 235337 Committed r171477: <http://trac.webkit.org/changeset/171477>
WebKit Commit Bot
Comment 6 2014-07-23 07:57:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.