Bug 135180

Summary:

REGRESSION (WebKit2): Selection inside accelerated overflow:scroll doesn't track scrolling

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

WebKit2

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cmarcelo, commit-queue, jamesr, japhet, luiz, simon.fraser, tonikitoo

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Enrica Casucci 2014-07-22 15:15:41 PDT

Create a selection inside an accelerated overflow.
Scroll inside the area.
The selection stays at the original position.

<rdar://problem/16721055>

Comment 1 Enrica Casucci 2014-07-22 15:45:33 PDT

Created attachment 235320 [details]
Patch

Comment 2 Simon Fraser (smfr) 2014-07-22 16:00:56 PDT

Comment on attachment 235320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235320&action=review

> Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:315
> +#if PLATFORM(IOS)
> +        if (scrollingLayerPositionAction == SetScrollingLayerPosition)
> +            m_page->editorClient()->updateSelection();
> +#endif

Can we push this #ifdef down into editorClient, giving EditorClient an overflowScrollPositionnChanged(bool) which is not #ifdeffed, and only implementing for iOS?

This would be better than having #if PLATFORM(IOS) in core code.

Comment 3 Enrica Casucci 2014-07-22 16:29:09 PDT

Committed revision 171370.

Comment 4 Brent Fulgham 2014-07-23 09:00:08 PDT

This introduced a build failure on Windows due to a missing implementation of 'overflowScrollPositionChanged'.

Build fix landed: <http://trac.webkit.org/changeset/171403>