Bug 135180

Summary: REGRESSION (WebKit2): Selection inside accelerated overflow:scroll doesn't track scrolling
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: WebKit2Assignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cmarcelo, commit-queue, jamesr, japhet, luiz, simon.fraser, tonikitoo
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Enrica Casucci
Reported 2014-07-22 15:15:41 PDT
Create a selection inside an accelerated overflow. Scroll inside the area. The selection stays at the original position. <rdar://problem/16721055>
Attachments
Patch (21.66 KB, patch)
2014-07-22 15:45 PDT, Enrica Casucci 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2014-07-22 15:45:33 PDT
Created attachment 235320 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-07-22 16:00:56 PDT
Comment on attachment 235320 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235320&action=review > Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:315 > +#if PLATFORM(IOS) > + if (scrollingLayerPositionAction == SetScrollingLayerPosition) > + m_page->editorClient()->updateSelection(); > +#endif Can we push this #ifdef down into editorClient, giving EditorClient an overflowScrollPositionnChanged(bool) which is not #ifdeffed, and only implementing for iOS? This would be better than having #if PLATFORM(IOS) in core code.
Enrica Casucci
Comment 3 2014-07-22 16:29:09 PDT
Committed revision 171370.
Brent Fulgham
Comment 4 2014-07-23 09:00:08 PDT
This introduced a build failure on Windows due to a missing implementation of 'overflowScrollPositionChanged'. Build fix landed: <http://trac.webkit.org/changeset/171403>
Note You need to log in before you can comment on or make changes to this bug.