Bug 135146

Summary:

[ftlopt] Get rid of structure checks as a way of checking if a function is in fact a function

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

135145

Attachments:

Description	Flags
work in progress	none
the patch	oliver: review+

Description Filip Pizlo 2014-07-21 20:21:36 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2014-07-21 22:42:30 PDT

Created attachment 235268 [details]
work in progress

I accidentally wrote this against trunk.  It passes tests but I haven't checked performance.  I'll rebase it onto the branch and do performance testing there.

Comment 2 Filip Pizlo 2014-07-22 19:14:13 PDT

Created attachment 235338 [details]
the patch

Comment 3 Oliver Hunt 2014-07-22 20:49:57 PDT

Comment on attachment 235338 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235338&action=review

> Source/JavaScriptCore/dfg/DFGUseKind.cpp:42
> -        break;
> +        return;

i kind of wish the s/break/return/ change was separate but not enough to r- or anything :)

Comment 4 Filip Pizlo 2014-07-22 21:16:30 PDT

Landed in http://trac.webkit.org/changeset/171389